Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix guest lookup to be unscoped #2395

Merged
merged 5 commits into from
Dec 18, 2024
Merged

fix guest lookup to be unscoped #2395

merged 5 commits into from
Dec 18, 2024

Conversation

orangewolf
Copy link
Member

guests fail to to find the existing guest account because of the default scope.

@orangewolf orangewolf added the patch-ver for release notes label Dec 5, 2024
Copy link

github-actions bot commented Dec 6, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 56s ⏱️ -11s
2 055 tests +2  1 999 ✅  - 4  56 💤 +6  0 ❌ ±0 
2 082 runs  +2  2 024 ✅  - 4  58 💤 +6  0 ❌ ±0 

Results for commit 5e6149c. ± Comparison against base commit 6ad1bb1.

This pull request removes 45 and adds 47 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 87f978cc-7e42-4653-b894-cd762d233f8a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 94a3670d-36f3-469c-b340-63c899bc3845
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4a41a15d-f9e2-4cc3-a6b3-23734167dfd1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update e68eb167-ec7c-4154-83cf-41750f1e7f66
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy baecde98-9458-4fcf-b7dd-cc7a4c090559
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 911799d1-6851-4653-94ee-1112dac6d16e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 0b9402c7-b15e-4a50-ac61-7b909bceb472
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 359c250e-a2ac-4fd2-b69b-f2825f8bc9ae
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a06ce8ea-af26-41d6-bdb9-17851838f8d5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e5392b88-33e6-407e-9c20-a6b3b2a85360
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 99686f9a-cabc-4fc1-9e9c-01f1edb35d5e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 2aaaa250-e536-4087-bbb3-61b0c5f166a7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 89593d6c-83fa-47c7-947f-fc71c4b74d6b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1f46e9d6-dba7-498a-9208-266301bbebf9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy e0ca58ea-76a1-442c-a50f-d533568aaf06
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 08a60dc5-ea9f-474e-aecc-580c5bdd08b9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 291bd4b7-55b5-4014-ae20-cfc244bd99a5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 089d0316-3b96-4524-9338-33ce3c1b85f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy cd8fa88f-4811-4005-a649-bc9f756172e5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 2cebaa29-4eaa-4b98-9e82-65a11174ed02
…
This pull request skips 3 tests.
spec.features.appearance_theme_spec ‑ Admin can select home page theme when a search results theme is selected updates to the users preferred view
spec.features.create_etd_spec ‑ Create a Etd a logged in user with the :work_depositor role can create an Etd
spec.features.work_editor_role_spec ‑ Work Editor role create permissions can create a work

♻️ This comment has been updated with latest results.

ShanaLMoore
ShanaLMoore previously approved these changes Dec 18, 2024
@@ -0,0 +1,26 @@
# frozen_string_literal: true

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An override comment could be useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear there was one. but yes I 100% agree with you

@orangewolf orangewolf merged commit 012cb43 into main Dec 18, 2024
2 checks passed
@orangewolf orangewolf deleted the guest_fix branch December 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants