-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix guest lookup to be unscoped #2395
Conversation
Test Results 3 files ±0 3 suites ±0 17m 56s ⏱️ -11s Results for commit 5e6149c. ± Comparison against base commit 6ad1bb1. This pull request removes 45 and adds 47 tests. Note that renamed tests count towards both.
This pull request skips 3 tests.
♻️ This comment has been updated with latest results. |
@@ -0,0 +1,26 @@ | |||
# frozen_string_literal: true | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An override comment could be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I swear there was one. but yes I 100% agree with you
guests fail to to find the existing guest account because of the default scope.