Pacify the cops

samvera · Oct 11, 2024 · a0ee2bf · a0ee2bf
1 parent a89b634
commit a0ee2bf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/lib/wings/active_fedora_converter.rb b/lib/wings/active_fedora_converter.rb
@@ -143,7 +143,7 @@ def apply_attributes_to_model(af_object)
     end
     # rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength
 
-    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     def parse_attributes(af_object)
       converted_attrs = normal_attributes
       af_object.attributes = converted_attrs.except(:members, :files, :file_name)
@@ -163,14 +163,10 @@ def parse_attributes(af_object)
       files = converted_attrs.delete(:files)
       af_object.files.build_or_set(files) if files
     end
-    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
     def convert_based_near(based_near_string)
-      converted_based_near = []
-      based_near_string.each do |bn|
-        converted_based_near << Hyrax::ControlledVocabularies::Location.new(bn)
-      end
-      converted_based_near
+      based_near_string.map { |bn| Hyrax::ControlledVocabularies::Location.new(bn) }
     end
 
     def create_extrated_text(af_object)

diff --git a/spec/wings/active_fedora_converter_spec.rb b/spec/wings/active_fedora_converter_spec.rb
@@ -125,9 +125,11 @@
 
     context 'when given a valkyrie native model' do
       let(:based_near) { "https://sws.geonames.org/4920808/" }
-      let(:resource) { klass.new(title: ['comet in moominland'],
-                                 distant_relation: ['Snufkin'],
-                                 based_near: [based_near]) }
+      let(:resource) do
+        klass.new(title: ['comet in moominland'],
+                  distant_relation: ['Snufkin'],
+                  based_near: [based_near])
+      end
       let(:klass) { Hyrax::Test::Converter::Resource }
 
       before do

diff --git a/spec/wings/attribute_transformer_spec.rb b/spec/wings/attribute_transformer_spec.rb
@@ -5,7 +5,7 @@
 require 'wings/attribute_transformer'
 
 RSpec.describe Wings::AttributeTransformer, :active_fedora do
-  let(:id)   { 'moomin123' }
+  let(:id) { 'moomin123' }
   let(:based_near) { Hyrax::ControlledVocabularies::Location.new("https://sws.geonames.org/4920808/") }
   let(:work) { GenericWork.new(id: id, **attributes) }
 
@@ -14,7 +14,7 @@
       title: ['fake title', 'fake title 2'],
       contributor: ['user1'],
       description: ['a description'],
-      based_near:[based_near]
+      based_near: [based_near]
     }
   end