Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6755 #6896

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Issue 6755 #6896

merged 2 commits into from
Sep 18, 2024

Conversation

jlhardes
Copy link
Contributor

Fixes

Adds override for blue background color used by Bootstrap to use a blue with color contrast greater than 7:1. This passes WCAG 2.2 Level AAA requirements.

Fixes #6755

Summary

Based on Bootstrap 4.6.2 variable styles in use with current Hyrax, there are known accessibility problems with some color contrasts. Overriding the color assigned to this blue variable makes sure anything using that color (primary class, at least) will contrast enough for accessibility.

Type of change (for release notes)

  • notes-minor Accessibility fix

@samvera/hyrax-code-reviewers

Copy link

Test Results

    17 files  ±0      17 suites  ±0   2h 19m 2s ⏱️ + 3m 2s
 6 706 tests ±0   6 409 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 180 runs  ±0  12 785 ✅ ±0  395 💤 ±0  0 ❌ ±0 

Results for commit 1aca567. ± Comparison against base commit b02cd98.

This pull request removes 274 and adds 274 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f85c3a571c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa53e858488>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f85c4817e40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa53e851f48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ff08b3dc-f1d9-4760-bfd5-fd0f347c5e73
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4ef7fb64-eb80-4bb9-a2a4-35b58635c2d9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: d647f373-8ac8-4b8f-827c-b2faeb013b86
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: b3d3583b-4239-4724-b780-7f5ed63aaf05
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: e1c263d2-aee5-4c33-8070-665d7ddeaeb9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: b4fbc8fb-8810-4029-ae4a-f143dc92917c
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9212b85500>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa664c885e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f92138ce388>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa664ad6b98>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 09796b3c-196a-4594-8487-d2c3c688ded1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: c762aac5-27c0-4b55-9502-adc9cbfedadf
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: d700ce10-1af0-40f5-a458-071e00a5a02f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: b2995ddd-0a70-4b4e-a707-aafb27170001
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: b16bc76f-a3b6-4bc8-845a-40442c1018aa
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 22f949c0-f0d0-4a11-a2ed-8585d2d51d06
…

@orangewolf orangewolf merged commit 0a14163 into main Sep 18, 2024
22 checks passed
@orangewolf orangewolf deleted the issue-6755 branch September 18, 2024 15:39
@orangewolf orangewolf added the notes-bugfix Release Notes: Fixed a bug label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposited badge on work show page does not meet color contrast accessibility requirements
3 participants