Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy migrate characterization along with file #6914

Merged
merged 15 commits into from
Oct 14, 2024

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Oct 4, 2024

Fixes

When migrating file_sets, the actual file is currently transfering, but file characterization data is getting lost. This fix prevents the file characterization data (such as height and width) from going missing after saving to Postgres or Fcrepo 6 from a perviously saved Fcrepo 4 object.

Changes proposed in this pull request:

  • Fix characterization fields going missing on transfer of FileSets from fcrepo 4 to postgres
  • Make sure custom queries are loaded when ever the Goddess adapters are loaded [1]
  • Default resource_class_resolver for Valkyrie objects should use the model registry [1]
  • Improve the spec helpers to make testing freyja and frigg adapters easier

[1] - Both of these two points are things we have been putting in all the config/initializer/wings.rb files when we enable Freyja. In order to get specs working for this migration issue, we needed to pull them in to Hyrax. It seemed better to make the included instead of duplicating the logic in the spec helpers.

@laritakr laritakr added notes-valkyrie Release Notes: Valkyrie specific notes-bugfix Release Notes: Fixed a bug and removed notes-valkyrie Release Notes: Valkyrie specific labels Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 38s ⏱️ - 3m 25s
 6 707 tests +1   6 410 ✅ +2  297 💤 ±0  0 ❌  - 1 
13 183 runs  +3  12 787 ✅ +3  396 💤 +1  0 ❌  - 1 

Results for commit 003e122. ± Comparison against base commit f77472d.

This pull request removes 274 and adds 275 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f80f4cedc00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8fb92ccba8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f80f4c4be00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8fb84e7ee8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5df7d499-6552-4102-a913-86d67630c8ea
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 8eadeeb8-f856-4737-8542-0bdf7aabe98d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: f6496b1c-b929-4fa3-ab68-b84844f3e73b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 634b6383-85a4-4961-b70a-2d896515ab43
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3a4668fc-88bf-437c-b4da-278ff5853330
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: e08b6f6a-c456-4f0c-8df3-78bae20aeccf
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fddd285e398>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fef1230d988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fddd1e44600>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fef0c3f4898>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: e635d2cb-c7f8-4f9f-a942-326ad2560fab
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: acd3afae-b5c7-4bf7-b093-c3b02af3d048
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 32d1932d-6239-4297-9a75-8fd6b74b7869
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 94df5579-c67f-4a6d-a960-0f24619e3316
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 1a650506-81c7-4202-bf97-03fd846b719f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 855af1ae-9f2f-4009-bb19-342bbc71694b
…

♻️ This comment has been updated with latest results.

@orangewolf orangewolf marked this pull request as ready for review October 11, 2024 00:17
@orangewolf orangewolf changed the title WIP: Lazy migrate characterization along with file Lazy migrate characterization along with file Oct 11, 2024
dlpierce
dlpierce previously approved these changes Oct 11, 2024
@orangewolf orangewolf merged commit be73c6f into main Oct 14, 2024
22 checks passed
@orangewolf orangewolf deleted the lazy-migrate-characterization branch October 14, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants