-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy migrate characterization along with file #6914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
added
notes-valkyrie
Release Notes: Valkyrie specific
notes-bugfix
Release Notes: Fixed a bug
and removed
notes-valkyrie
Release Notes: Valkyrie specific
labels
Oct 4, 2024
Test Results 17 files ±0 17 suites ±0 2h 17m 38s ⏱️ - 3m 25s Results for commit 003e122. ± Comparison against base commit f77472d. This pull request removes 274 and adds 275 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
orangewolf
changed the title
WIP: Lazy migrate characterization along with file
Lazy migrate characterization along with file
Oct 11, 2024
dlpierce
previously approved these changes
Oct 11, 2024
…mvera/hyrax into lazy-migrate-characterization
orangewolf
approved these changes
Oct 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
When migrating file_sets, the actual file is currently transfering, but file characterization data is getting lost. This fix prevents the file characterization data (such as height and width) from going missing after saving to Postgres or Fcrepo 6 from a perviously saved Fcrepo 4 object.
Changes proposed in this pull request:
[1] - Both of these two points are things we have been putting in all the config/initializer/wings.rb files when we enable Freyja. In order to get specs working for this migration issue, we needed to pull them in to Hyrax. It seemed better to make the included instead of duplicating the logic in the spec helpers.