Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed visitors count and downloads counts for each daatset #47

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KarishmaVanwari
Copy link

Description

The website did not have visitor count and downloads count. I made the changes and now it shows the visitiors count next to dataset heading. Also, now the download count for each dataset is shown.

Fixes #8

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS

screencapture-127-0-0-1-5500-index-html-2021-10-02-20_53_12

@netlify
Copy link

netlify bot commented Oct 2, 2021

✔️ Deploy Preview for zen-visvesvaraya-18f5e7 ready!

🔨 Explore the source changes: 9b2794f

🔍 Inspect the deploy log: https://app.netlify.com/sites/zen-visvesvaraya-18f5e7/deploys/6158aa54cd3d050007d55416

😎 Browse the preview: https://deploy-preview-47--zen-visvesvaraya-18f5e7.netlify.app/

@samz5320
Copy link
Owner

samz5320 commented Oct 2, 2021

there is an error. it says Nan instead of displaying the number of downloads. you can see it in the preview

@KarishmaVanwari
Copy link
Author

there is an error. it says Nan instead of displaying the number of downloads. you can see it in the preview

Okay, I'll fix this

@KarishmaVanwari
Copy link
Author

Please do check it now @samz5320

@samz5320
Copy link
Owner

samz5320 commented Oct 2, 2021

Screenshot 2021-10-02 at 11 44 45 PM

It is working for some datasets and not for the rest. I think we should avoid the views count for now as it is being stored in browser storage.

@samz5320
Copy link
Owner

samz5320 commented Oct 2, 2021

You can use the preview deployed link to test ur changes

@KarishmaVanwari
Copy link
Author

Screenshot 2021-10-02 at 11 44 45 PM

It is working for some datasets and not for the rest. I think we should avoid the views count for now as it is being stored in browser storage.
data4all

I guess it shows fine, as you can see, but I don't get why are the two screenshots showing different results.

@samz5320
Copy link
Owner

samz5320 commented Oct 2, 2021

Can you git pull to update your repo. and then you can add your changes.. also copy your ur changes to another file.

@KarishmaVanwari
Copy link
Author

data4all-ss

I have done git pull, but it still shows the number of downloads properly (for the datasets that I changed).

@samz5320
Copy link
Owner

samz5320 commented Oct 3, 2021

I think we have to work out a new design for this.

@KarishmaVanwari
Copy link
Author

KarishmaVanwari commented Oct 3, 2021

I think we have to work out a new design for this.

Could you merge the visitors count part if create another pr of changes only for the same? @samz5320

@samz5320
Copy link
Owner

samz5320 commented Oct 4, 2021

i cannot merge the current PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display number of downloads of datasets and visits to page
2 participants