Dev/location test pr #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check the logic for updating and modifying paths, Location to check the full path, fix circular build error -- Server.cpp
… in ckass: HttpResponse
san-ghun
requested changes
Jul 26, 2024
| std::string _extractPathFromUri(const std::string& uri); | ||
| std::string _getMatchedLocation(std::string path, | ||
| const std::map<std::string, | ||
| Location*>& locations); |
There was a problem hiding this comment.
24, 25 줄에 있는 함수들은 왜 클래스 밖에 따로 선언하셨나요? 특별한 이유가 있을까요??
There was a problem hiding this comment.
함수 위치가 확정이 안되서요. 따로 변경사항 없으면 나중에 member로 넣을거에요.
| /// @brief Generates an HTML page with a directory listing. | ||
| /// @param path | ||
| /// @return Create a list of directories and files in HTML and export it to std::stringstream. | ||
| std::string genDirListingHtml(const std::string& path) |
There was a problem hiding this comment.
이 함수는 클래스에서 따로 빼신거 잘 하신거 같아요. 어차피 나중에 디렉토리에 직접 탐색해서 있는 파일들 이름으로 하이퍼링크를 달면 될 거 같아서, 클래스에서 따로 빼서 쓰는 것도 좋은 선택인거 같네요.
There was a problem hiding this comment.
오 그것도 좋은 생각입니다! 사실 이 함수도 일단은 member로 넣을 이유가 크게 없어서 빼둔건데 계속 유지하는거로 생각할게요!
src/server/StaticFileHandler.cpp
Outdated
| { | ||
| // if (/* && location.location.isListDir() */) | ||
| // return (_handleDirListing(request, location)); | ||
| return (_handleDirRequest(request, location)); |
There was a problem hiding this comment.
이거는 보정이 필요해 보입니다. 탭이 너무 많네요... ㅎ
|
|
||
| std::cout << "TEST | absolute path that with index is built: " << _handledPath << std::endl; | ||
| if (isFile(_handledPath)) | ||
| return (_handleNotFound()); |
There was a problem hiding this comment.
line 91: The condition is wrong.
- I think you wanted to do like this:
if (!isFile(_handledPath))
return (_handleNotFound());There was a problem hiding this comment.
이런 치명적인 실수를. 감사합니다, 수정할게요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the import of Config and Location classes and the creation of the correct response.
extinmime-typelist so that it does not contain.tested: