Feat/request #5
Feat/request #5
Conversation
todo: test method
… necessary parts of some functions.
update: doc, todo: Check for sustainable connectivity, especially fromFile, which is only tested on .html files yet.
include/StaticFileHandler.hpp
Outdated
| # include "HttpRequest.hpp" | ||
| # include "HttpResponse.hpp" | ||
|
|
||
| # define FOLDER_PATH "./www/static" |
There was a problem hiding this comment.
Just would like to let you know that the default directory should and will be set by the Config file in future.
There was a problem hiding this comment.
Yes. Thanks for letting me know. Please remind me to handle this linking part later when you give the relevant PR.
src/server/HttpResponse.cpp
Outdated
| } | ||
|
|
||
| std::string getDefualtPagePath(int page_code) |
There was a problem hiding this comment.
- The "default page" is an .html file that is default for certain directory, the filename something like "index.html", but the method is currently dealing with error page, instead.
- I think the name of the method would better with "getErrorPage".
- Typo,
getDefualtPagePath()->getDefaultPagePath()
There was a problem hiding this comment.
Ah, now that I think about it again, Let's just go to getErrorPage
src/server/StaticFileHandler.cpp
Outdated
| return ("application/octet-stream"); | ||
| } | ||
|
|
||
| bool StaticFileHandler::fileExists(const std::string path) const |
There was a problem hiding this comment.
혹시 얘는 어디에 쓰시려고 만드신 거 일까요? 사용처를 못 찾아서 ;;;
There was a problem hiding this comment.
staticFileHandler.cpp
line 32 if (!fileExists(filePath))
There was a problem hiding this comment.
I'm not sure whether to continue using the method or not, so I didn't write a separate doc for: the name specifies the function feature. sorry!
src/server/HttpResponse.cpp
Outdated
| /// @return HttpResponse The created HttpResponse object. | ||
| HttpResponse HttpResponse::fromFile(const std::string filePath) | ||
| HttpResponse HttpResponse::fromFile(const std::string file_path) |
There was a problem hiding this comment.
- Suggestion: How about making another constructor for HttpResponse class that take an input parameter of
file_pathto initiate, instead of using a method to make and return an instance of it.
HttpResponse::HttpResponse(const std::string file_path)
: _statusCode(200), _statusMessage("OK")
{
fromFile(file_path);
}There was a problem hiding this comment.
Great, I'll update to reflect that.
|
Also thanks for your debug configuration with vscode. |
src/server/StaticFileHandler.cpp
Outdated
| return ("application/octet-stream"); | ||
| } | ||
|
|
||
| bool StaticFileHandler::fileExists(const std::string path) const |
There was a problem hiding this comment.
staticFileHandler.cpp
line 32 if (!fileExists(filePath))
src/server/HttpResponse.cpp
Outdated
| /// @return HttpResponse The created HttpResponse object. | ||
| HttpResponse HttpResponse::fromFile(const std::string filePath) | ||
| HttpResponse HttpResponse::fromFile(const std::string file_path) |
There was a problem hiding this comment.
Great, I'll update to reflect that.
src/server/HttpResponse.cpp
Outdated
| } | ||
|
|
||
| std::string getDefualtPagePath(int page_code) |
There was a problem hiding this comment.
Ah, now that I think about it again, Let's just go to getErrorPage
include/StaticFileHandler.hpp
Outdated
| # include "HttpRequest.hpp" | ||
| # include "HttpResponse.hpp" | ||
|
|
||
| # define FOLDER_PATH "./www/static" |
There was a problem hiding this comment.
Yes. Thanks for letting me know. Please remind me to handle this linking part later when you give the relevant PR.
src/server/StaticFileHandler.cpp
Outdated
| return ("application/octet-stream"); | ||
| } | ||
|
|
||
| bool StaticFileHandler::fileExists(const std::string path) const |
There was a problem hiding this comment.
I'm not sure whether to continue using the method or not, so I didn't write a separate doc for: the name specifies the function feature. sorry!
A simple request/response implementation that can be used for testing.
GET: parse the request and send the appropriate response via handleRequest.But not sure what,
and extra: I added the debug conf-available in vscode as a sample.
You can use it loosely and feel free to modify it.