-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace support #9
base: master
Are you sure you want to change the base?
Conversation
@Charnelx -- thanks a lot for this! I like the approach you're taking for BadgerFish. Do you have any suggestions on how we could do this for other conventions? We don't necessarily have to implement them. But deciding on their specification can help iron-out any inconsistencies in the BadgerFish namespace convention as well. Also, you may want to re-work the test cases ensure the Travis checks pass. |
@sanand0 thanks for having time to look at my code!
Yes i have an idea of how to add support for other convention types but this needs total code refactory. The main problem is still support for both xml and lxml.
Yes, i'll do that. It's little strange because locally tests pass without errors |
So it's just the GData convention that needs namespaces then. |
Good, i'll look what we can do with GData then. |
Has there been any more work done to support namespaces in GData? |
@fireundubh -- unfortunately, I haven't received a pull request subsequently. No work is happening on namespaces that I know of |
Hi.
I tried to add namespace support for BadgerFish converter.
The main problem i have faced - support for standard xml library and lxml. Their namespace implementation slightly differs so there is no simple methods to support them both in one way.
Because of a lack of experience my code is messy, sorry.
My implementation stands for one idea - give on the output exact thing that were received on the input.
Now examples of use:
If you have some questions - ask, will be glad to answer.