[241] Implement editing signature signer #265
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| import { CreateSignatureDto } from './create-signature.dto'; | ||
|
|
||
| export class UpdateSignatureSignerDto extends PartialType( | ||
| OmitType(CreateSignatureDto, ['order'] as const), |
There was a problem hiding this comment.
Any reason we would want to not change the order of a signature?
I know form instances inherit from form templates so messing with the order of signatures messes with the invariant that form instances have the same number + order of signatures as its form template, but do we think that employees would want to change the order in specific edge cases?
There was a problem hiding this comment.
We can extend the functionality to include updating the order, but we would also have to figure out how that works. How would we determine how to adjust the order? And we would have to adjust the order for every signature on the form as well.
| import { UpdateSignatureSignerDto } from './dto/update-signature-signer.dto'; | ||
| import { SignerType } from '@prisma/client'; | ||
|
|
||
| let mockSignatureService = { |
There was a problem hiding this comment.
I finally understand what a mock is (thanks sweng!) so good job on this
Description
Implement service and controller for editing signature signers
Motivation and Context
Allows users to be able to modify who is able to sign for a signature.
Closes [#241]
How has this been tested?
Unit testing.
Screenshots (if appropriate):
Types of changes
Checklist: