mesh adaptation: add MeshFields SPR support #1157
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porting from meshfields/test/testSprThwaitesAdapt.cpp
bartgol
approved these changes
Nov 7, 2025
|
|
||
| #include <Panzer_IntrepidFieldPattern.hpp> | ||
|
|
||
| //FIXME! |
Collaborator
There was a problem hiding this comment.
What's the FIXME about? Meaning, what is wrong with the code below that we need to keep in mind?
Collaborator
Author
There was a problem hiding this comment.
Thanks for asking; I forgot about this. Is there a better/cleaner way to use the exec/mem space that Albany is using?
Collaborator
There was a problem hiding this comment.
In Albany_KokkosTypes.hpp there are some types that may help. It all comes out of PHX::Device.
src/landIce/CMakeLists.txt
Outdated
| set_target_properties(landIce PROPERTIES PUBLIC_HEADER "${HEADERS}") | ||
| target_link_libraries(landIce PUBLIC albanyLib) | ||
| if (ALBANY_OMEGAH) | ||
| target_link_libraries(landIce PUBLIC Omega_h::omega_h) |
Collaborator
There was a problem hiding this comment.
I am not sure why we link omegah to landIce. We don't explicitly use omegah stuff in landice, and it is already linked indirectly through albany lib.
I think we can remove these two lib linking...
| # 2d test | ||
| configure_file(${CMAKE_CURRENT_SOURCE_DIR}/input_2d_omegah.yaml | ||
| ${CMAKE_CURRENT_BINARY_DIR}/input_2d_omegah.yaml COPYONLY) | ||
| add_test(${testName}_2d_omegah ${SerialAlbany.exe} input_2d_stk.yaml) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds MeshFields as a new TPL that provides a superconvergent patch recovery implementation to compute a size field to drive mesh adaptation. A 2d adaptive version of the 2d transient stk test
tests/corePDEs/AdvDiff/input_2d_stk.yamlwas added to exercise the functionality.CMake flags to enable UVM support in Omega_h is included in this PR and was tested on Perlmutter GPU.