Fix boost format logging #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 3.10, pdu_split has been upstreamed, so this removes that block from pdu_utils. Signed-off-by: Ed Beroset <beroset@ieee.org>
As of 3.10, the take_skip_to_pdu block is now upstreamed, so it is no longer needed here. Signed-off-by: Ed Beroset <beroset@ieee.org>
As of 3.10, pdu_set_m has been upstreamed (as pdu_set in gr-pdu), so this removes that block from pdu_utils. Signed-off-by: Ed Beroset <beroset@ieee.org>
As of 3.10, tags_to_pdu has been upstreamed, so this removes that block from pdu_utils. Signed-off-by: Ed Beroset <beroset@ieee.org>
As of 3.10, pdu_to_bursts has been upstreamed (as pdu_to_stream in gr-pdu), so this removes that block from pdu_utils. Signed-off-by: Ed Beroset <beroset@ieee.org>
Two problems have occurred in building this with the latest 3.10. First, boost::format needs the #include <boost/format.hpp> header. Second, there are problems when trying to use boost::format with the version of format that is used with spdlog. This resolves both issues and also adds a required #include <bitset> that caused one file to no longer compile. Signed-off-by: Ed Beroset <beroset@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of problems that seem to be related to changes in upstream (grc). Specifically, changes were made to spdlog and libfmt in the upstream that cause gr-pdu_utils to no longer build. This addresses that issue and it is based atop the code in #21. Therefore, accepting only this PR would be sufficient to address both this new issues and the ones addressed by the previous PR. This fixes #20