Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table printer / BDD step for creating persistent resource / asset fixtures #18

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

erickloss
Copy link
Contributor

@erickloss erickloss commented Sep 20, 2022

for now, only ImageInterface is supported. Other asset types must also be implemented.

also fixes: #13 #9

I tried to keep the Neos specific logic outside of the package, but added a hook / README.
When run with Neos/Flow After importing asset fixtures, resource:publish must be called somehow with the SUT context.

  • better handling of fixture base paths (currently, the absolute file path is printed)
  • finalize documentation about how to create /use persistent resource / asset fixtures
  • add handling for more than ImageInterface typed node properties (other Neos.Media models extending Asset)

please give feedback <3 see comments in the PR

cheers

README.md Outdated
- e2e-results
- styleguide
reports:
junit: e2e-results/behat.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier war der autoformatter etwas wild, oder? ;)

README.md Outdated

public function homepageCommand()
{
$fixtureBasePath = TODO !!!! FIX DOC !!!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nitpicks :)

@erickloss
Copy link
Contributor Author

This change should be downwards compatible. (pls recheck briefly)

Followup Ticket: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants