Merge branch 'url_encode_paths_for_s3_download' into 'main'

URL encode paths for S3 download See merge request sanger-pathogens/pipelines/nano-rave!23
sanger-pathogens · Jan 11, 2023 · 80cdd41 · 80cdd41
2 parents a0e638c + b4e0a13
commit 80cdd41
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/scripts/download_test_data.py b/scripts/download_test_data.py
@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 
 import xml.etree.ElementTree as ET
+import urllib.parse as urlparse
 import urllib.request as urlrequest
 from pathlib import Path
 import shutil
@@ -57,7 +58,7 @@ def fetch_index(continuation_token = None) -> Tuple[List[str], Optional[Any]]:
 
 
 def download_file(path: str):
-    url = BUCKET_URL + "/" + path
+    url = BUCKET_URL + "/" + urlparse.quote_plus(path)
 
     # Note: '/' operator joins paths
     dest = OUTPUT_DIR / path