Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-190: Support v2 searches #4616

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Y24-190: Support v2 searches #4616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d37651
Add a state filter for labware
sdjmchattie Jan 13, 2025
d86470e
Fix a typo in the state.rb file comments
sdjmchattie Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/transfer/state.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def self.included(base) # rubocop:todo Metrics/MethodLength
states = Array(states).map(&:to_s)

# If all of the states are present there is no point in actually adding this set of conditions because
# we're basically looking for all of the plates.
# we're basically looking for all of the tubes.
if states.sort != ALL_STATES.sort
join_options = [
# rubocop:todo Layout/LineLength
Expand Down
1 change: 1 addition & 0 deletions app/resources/api/v2/shared_behaviour/labware.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ module Labware
filter :updated_at_gt,
apply: lambda { |records, value, _options| records.where('labware.updated_at > ?', value[0].to_date) }
filter :include_used, apply: ->(records, value, _options) { records.include_labware_with_children(value) }
filter :state, apply: ->(records, value, _options) { records.in_state(value.flatten) }
end

# Custom methods
Expand Down
Loading