feat(animations): add animations to dialog and tooltips. #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
pedrobonamin
force-pushed
the
alpha-animations
branch
from
121d090 to
44cb29a
Compare
pedrobonamin
changed the title
robinpyon
force-pushed
the
alpha-animations
branch
from
a1c214f to
426d48f
Compare
robinpyon
force-pushed
the
alpha-animations
branch
from
426d48f to
2a1a15b
Compare
This reverts commit 3a19fb9.
robinpyon
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks @pedrobonamin!
Tooltip animations look and feel great, would be awesome if we could facilitate exit animations in dialogs too, but understand how this could be a little tricky
mariuslundgard
pushed a commit
that referenced
this pull request
Dec 7, 2023
* feat(animations): add presence animations to tooltip * feat(animations): add animation to dialog * chore(storybook): pass story args to delay provider * chore: update TSdocs to make them more storybook friendly * fixup! chore: update TSdocs to make them more storybook friendly * Revert "chore(storybook): pass story args to delay provider" This reverts commit 3a19fb9.
This was referenced Jan 15, 2024
robinpyon
pushed a commit
that referenced
this pull request
Jan 16, 2024
* feat(animations): add presence animations to tooltip * feat(animations): add animation to dialog * chore(storybook): pass story args to delay provider * chore: update TSdocs to make them more storybook friendly * fixup! chore: update TSdocs to make them more storybook friendly * Revert "chore(storybook): pass story args to delay provider" This reverts commit 3a19fb9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds animation to Dialog and Tooltips.
<AnimatePresence>wrapper would need to be added in the consumer and not in the ui component, given that the Dialog don't receive ashowprop, and that logic is handled in the consumers.Dialog.animation.mov
Screen.Recording.2023-11-18.at.10.51.20.mov