handle undef comparison to blank street not printing warnings to stderr

sanko · Feb 2, 2024 · 4b755b1 · 4b755b1
1 parent c1a5ac8
commit 4b755b1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/lib/Template/Liquid/Condition.pm b/lib/Template/Liquid/Condition.pm
@@ -96,6 +96,9 @@ sub _equal {    # XXX - Pray we don't have a recursive data structure...
     my $ref_l = ref $l;
     return !1 if $ref_l ne ref $r;
     if (!$ref_l) {
+        if(!defined $l or !defined $r) {
+          return !1;
+        }
         return
               !!(grep {defined} $l, $r)
             ? (grep {m[\D]o || m[^$]} $l, $r)

diff --git a/t/0200_tags/02006_if.t b/t/0200_tags/02006_if.t
@@ -322,23 +322,35 @@ INPUT
 Nope
 EXPECTED
 is( Template::Liquid->parse(
-        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check "" == 5');
+        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check "" != undef');
 {% if foo == bar %}Yep.{% else %}Nope{% endif %}
 INPUT
 Nope
 EXPECTED
 is( Template::Liquid->parse(
-        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check "" == 5');
+        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check if ""');
 {% if foo %}Yep.{% else %}Nope{% endif %}
 INPUT
 Nope
 EXPECTED
 is( Template::Liquid->parse(
-        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check "" == 5');
+        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check if undef');
 {% if bar %}Yep.{% else %}Nope{% endif %}
 INPUT
 Nope
 EXPECTED
+is( Template::Liquid->parse(
+        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check undef == ""');
+{% if mobile == "" %}BLANKMOBILE{% else %}NOTBLANK{% endif %}
+INPUT
+NOTBLANK
+EXPECTED
+is( Template::Liquid->parse(
+        <<'INPUT')->render(foo => "", bar => undef), <<'EXPECTED', 'Check undef == ""');
+{% unless mobile %}BLANKMOBILE{% else %}NOTBLANK{% endunless %}
+INPUT
+BLANKMOBILE
+EXPECTED
 
 
 # I'm finished