Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR updates ShipKit’s commit-message guidance to strictly control when a co-author trailer is added, and refreshes GitHub Actions workflows (checkout + CodeQL) to newer major versions / settings.
Changes:
- Tighten
/commit+stage-and-commitinstructions to forbid any co-author trailer unlesscommit.coAuthoris explicitly set to a non-null string in.shipkit.json. - Add clearer examples for commit messages with/without
commit.coAuthor. - Update GitHub Actions workflows to use newer
actions/checkoutandgithub/codeql-actionmajors, and adjust CodeQL language configuration.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skills/stage-and-commit.md | Clarifies when co-author trailers may be appended; adds examples. |
| commands/commit.md | Aligns /commit procedure with stricter co-author trailer rule. |
| .github/workflows/release.yml | Bumps checkout action major used during releases. |
| .github/workflows/codeql.yml | Switches CodeQL language to actions and bumps CodeQL/checkout action majors. |
| .github/workflows/ci.yml | Bumps checkout action major across CI jobs. |
| .claude/commands/skills/stage-and-commit.md | Mirrors the skills/ stage-and-commit guidance change for Claude. |
| .claude/commands/commands/commit.md | Mirrors the commands/ commit guidance change for Claude. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutv4 → v6 across all workflows (ci, codeql, release) — supersedes build(deps): bump actions/checkout from 4 to 6 #8github/codeql-actionv3 → v4 — supersedes build(deps): bump github/codeql-action from 3 to 4 #7javascript-typescripttoactions(repo has no JS/TS source code, causing the "Analyze" check to fail on both Dependabot PRs)stage-and-commitskill ensuring commits are attributed solely to the system's git user unlesscommit.coAuthoris configuredTest plan