don't match if there are no conditions

sansecio · Feb 10, 2025 · 62bf16c · 62bf16c
1 parent 2437f78
commit 62bf16c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Model/Rule.php b/Model/Rule.php
@@ -122,6 +122,6 @@ public function matches(RequestInterface $request): bool
                 return false;
             }
         }
-        return true;
+        return count($this->conditions) > 0;
     }
 }
diff --git a/Test/Model/RuleTest.php b/Test/Model/RuleTest.php
@@ -65,4 +65,10 @@ public function testRuleWithMultipleConditions()
 
         $this->assertTrue($rule->matches($request));
     }
+
+    public function testRuleWithoutConditions()
+    {
+        $rule = new Rule(new IP(), 'block', []);
+        $this->assertFalse($rule->matches($this->createMock(Http::class)));
+    }
 }