refactor: Extract Navbar component and update Dashboard/AboutUs screens#255
Open
KanhaiyaBagul wants to merge 1 commit intosantanu-atta03:mainfrom
Open
refactor: Extract Navbar component and update Dashboard/AboutUs screens#255KanhaiyaBagul wants to merge 1 commit intosantanu-atta03:mainfrom
KanhaiyaBagul wants to merge 1 commit intosantanu-atta03:mainfrom
Conversation
|
@KanhaiyaBagul is attempting to deploy a commit to the santanu-atta03's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for creating a PR for your Issue!
|
Owner
|
@KanhaiyaBagul please resolve the conflicts, and also attach the screenshots of the work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Extract Navbar Component and Update Dashboard/AboutUs
This PR refactors the navigation bar implementation by creating a reusable Navbar component and integrating it into Dashboard.jsx and AboutUs.jsx. This change eliminates significant code duplication and centralizes the navigation logic, making future updates easier and ensuring a consistent user experience.
Changes Made
dashboard: Sticky navbar with Notifications, User Profile, and Dashboard-specific links.public: Floating pill navbar with public navigation links (Features, About, etc.) and Auth buttons.<Navbar variant="dashboard" />.<Navbar variant="public" />.lucide-reacticons, hooks) and local state related to the old navigation logic from the page components.