Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40 introduced changes that broke some tests, namely through a change to
BpodLib.utils.getCurrentCOM. The change would cause it to fail to identify the COM, thereby reverting back to 'EMU'. The outcome would be that multi-setups may have configurations that are strangely tied to the 'EMU' setup.The bug has been fixed, and the test code has been updated to reflect the more robust approach.
Separately, the port array module's calibration file creation has been modified to handle different stages of setup (
.nModules) is guaranteed to exist in test contexts.