Remove the SerialPort field when the serial port fails to connect#43
Merged
sanworks merged 1 commit intosanworks:developfrom Nov 24, 2025
Merged
Remove the SerialPort field when the serial port fails to connect#43sanworks merged 1 commit intosanworks:developfrom
sanworks merged 1 commit intosanworks:developfrom
Conversation
austin2118ace
force-pushed
the
emu_fix
branch
from
ad83a18 to
beec37a
Compare
Contributor
Author
|
Goofed and didn't actually commit the fix. Ignore the force push bad developer. |
…herwise emulator mode does not properly start as SerialPort gets set to a deleted handle
austin2118ace
force-pushed
the
emu_fix
branch
from
beec37a to
11f0d0b
Compare
Contributor
|
Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to how
Connect2BpodSM.msetsBpodSystem.SerialPort, if there is no connection it is set to a deleted handle. This causes an error when attempting to launch the emulator, as the check ingetCurrentCom.mwill fail sinceSerialPortis a field of the BpodSystem, but it is just a deleted handle.This patch makes sure the SerialPort field is dropped from the BpodSystem if no connection is made so the emulator logic properly runs.
Cheers!