Improve handling for example calibration data on fresh setup#44
Merged
sanworks merged 6 commits intosanworks:developfrom Nov 24, 2025
Merged
Improve handling for example calibration data on fresh setup#44sanworks merged 6 commits intosanworks:developfrom
sanworks merged 6 commits intosanworks:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #42 the UIs were not properly triggered because the COM port field is absent. This PR:
"example data"COM for the example data which is recognised as being non-user data during COM match check.This ensures that UI warnings about COM mismatch are not triggered if the user is yet to even touch the liquid calibration data.
Note that the warnings concerning "old calibration" were turned off in bc33156 until a UI to opt in is built.