Improve LiquidCalibration.json COM mismatch UI#45
Merged
sanworks merged 3 commits intosanworks:developfrom Nov 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #42 it was noted that:
This PR should make it clearer what is happening by referring to the current machine's settings file as "(use existing file)".
An explanation
A LiquidCalibration.json has two COM properties: the one inside of its metadata and also the Config folder that the file lives within. During startup,
BpodLib.BpodObject.setup.updatePathAndSettings.mwill:For this reason, the current COM port will always be in the list of available Config sources. This UI handles the situation where a user replaces one state machine with another and the user copies across those config files. This allows the COM metadata to be overwritten without requiring a recalibration. It's sort of a niche use-case -- at some point we could build an interface to allow users to move configuration files around.
To produce the GUI you can use this snippet: