Open
Conversation
This was referenced Sep 7, 2025
Collaborator
austin2118ace
left a comment
austin2118ace
left a comment
There was a problem hiding this comment.
First pass; I haven't had any time recently to actually test code on Bpod hardware, so this is my superficial glance over things.
Collaborator
|
can you rebase onto dev and resync so the uv.lock file is current in your branch |
- Add functionality to PendingValve - Create add_valve_states - Add tests
- Functional state machine factory (but not hardware tested) - Easier parameter modification for state machine construction - Cleaner output action construction
Remove redundant Class from end of name.
Output actions haven't been tested because modules haven't been implemented in bpod-core
The exact nature of the unique id is TBD, but the information will be stored.
In anticipation of change to dev branch to use pytest
ogeesan
force-pushed
the
liquidcal-data
branch
from
9c6d31e to
8181af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Liquid calibration for Bpod state machine valves using object-oriented framework similar to Bpod_Gen2's implementation. An API that should be easily integrated into the GUI is implemented
Future work: