sap_ha_install_hana_hsr: Rework role with new features, validations and compatibility for 2.20 #1135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This has started as small PR to add variable for HOME folder path, but it turned out into complete rework of this role to catch it up with conventions that are followed on project level, as well as resolving ansible-core 2.20 warnings.
optionalkey comments, since none of them were optional, but mandatory.Tests
This was tested on SLES 15 SP7 on AWS with creating and removing configuration, as well as running idempotent reruns.
Tested with ansible-core 2.18 and 2.20.
Example output:
Enable replication with `sap_ha_install_hana_hsr_state: present`
Remove replication with `sap_ha_install_hana_hsr_state: absent`