Skip to content

[limes] use global.is_global_region in helm-charts #8436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

wagnerd3
Copy link
Contributor

@wagnerd3 wagnerd3 commented Apr 4, 2025

  • use global.is_global_region instead of deriving this info from the limes_url
  • use customer_domains = ["global"] from the values for the global region (less special logic)
  • replace contains "iaas-" with hasPrefix "iaas-" for more robustness

@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

@wagnerd3 wagnerd3 force-pushed the limes_seed_refactor_global_deployment branch from 2847e5e to f00677f Compare April 4, 2025 12:24
@majewsky
Copy link
Contributor

majewsky commented Apr 7, 2025

I presume you already ran this against global-qa? If not, please check the diff on CI.

@majewsky majewsky merged commit 8c46c3a into master Apr 7, 2025
2 checks passed
@majewsky majewsky deleted the limes_seed_refactor_global_deployment branch April 7, 2025 14:22
@wagnerd3
Copy link
Contributor Author

wagnerd3 commented Apr 7, 2025

I did not, else I would have seen that like for billing chart in global, we are missing the global:globals values. I will revert for now and check with you tomorrow whether the diff is fine, I found something odd there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants