Skip to content

Conversation

@renovate
Copy link

@renovate renovate bot commented Mar 30, 2024

This PR contains the following updates:

Package Change Age Confidence
express (source) 4.19.0 -> 4.20.0 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: serve-static@​0.16.0
    • Remove link renderization in html while redirecting
  • deps: send@​0.19.0
    • Remove link renderization in html while redirecting
  • deps: body-parser@​0.6.0
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: path-to-regexp@​0.1.10
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the security label Mar 30, 2024
@renovate
Copy link
Author

renovate bot commented Mar 30, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json

@renovate renovate bot changed the title Update dependency express to v4.19.2 [SECURITY] fix(deps): update dependency express to v4.19.2 [security] Jun 29, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 7707918 to f55d16b Compare September 22, 2024 05:49
@renovate renovate bot changed the title fix(deps): update dependency express to v4.19.2 [security] fix(deps): update dependency express to v4.20.0 [security] Sep 22, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from f55d16b to 32fc99d Compare October 11, 2024 05:06
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 32fc99d to edba33c Compare December 3, 2024 05:45
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from edba33c to d0c91ca Compare January 24, 2025 07:48
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from d0c91ca to bf0cea5 Compare February 9, 2025 20:07
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from bf0cea5 to b5901dc Compare March 5, 2025 23:56
@renovate renovate bot changed the title fix(deps): update dependency express to v4.20.0 [security] chore(deps): update dependency express to v4.20.0 [security] Sep 26, 2025
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from b5901dc to 6cf47dd Compare September 26, 2025 07:58
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 6cf47dd to 6dab15f Compare October 25, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant