Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: update eslint/prettier configs #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drmikecrowe
Copy link

@sapegin -- this is NOT ready for release yet, but wanted to show you my current code.

The latest eslint-config-prettier simplifies things considerably, so I updated my eslint task to migrate to the latest config.

Additionally, I added support for yarn and vue (both require some tweaks to the base code).

LMK if you want me to pursue this -- I'll have to fix the tests and see what else needs to be done

@sapegin
Copy link
Owner

sapegin commented Aug 3, 2021

Looks good so far!

There are two issues with the current approach in general (not with this pull request, these are more of thinking loud):

  1. Messy code with lots of conditions that's hard to read and maintain.
  2. No way to disable all the magic, which could be necessary when you use your own preset that may already include the plugins.

@everdimension
Copy link

Hello @sapegin!

Is this still being worked on?

As of prettier v8 https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21, current mrm prettier setup creates a config that produces an error:

Error: Cannot read config file: `//node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

Will this PR be merged eventually or should I help create a new one which just solves the above issue?

@sapegin
Copy link
Owner

sapegin commented Jul 4, 2023

@everdimension Please open a new pull request, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants