Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): add prettier rules if installed without TS #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonflk
Copy link

The problem

Currently, the task will only add the prettier rules if Typescript is also
installed.

What was changed

  • add eslint-config-prettier if prettier is installed, regardless of TS

Currently, it will only add the prettier rules if Typescript is also
installed
@FDiskas
Copy link

FDiskas commented Nov 17, 2020

why this is not merged yet?

@sapegin
Copy link
Owner

sapegin commented Nov 18, 2020

The problem is, not everyone needs this thing (even for TypeScript, so we need a way to disable this behavior).

@FDiskas
Copy link

FDiskas commented Nov 19, 2020

this can be as a question in interactive mode.

@FDiskas
Copy link

FDiskas commented Nov 19, 2020

Also I would suggest to add https://github.com/prettier/eslint-plugin-prettier
Currently prettier can help eslint to autofix styling issues.

@sapegin
Copy link
Owner

sapegin commented Nov 19, 2020

this can be as a question in interactive mode.

Yep.

Also I would suggest to add https://github.com/prettier/eslint-plugin-prettier
Currently prettier can help eslint to autofix styling issues.

I believe you can already define it in your config but we won't have it by default (or even with an option) because of the very bed developer experience it creates. We shouldn't treat unformatted code as an error and distract developers but format it silently on commit.

@FDiskas
Copy link

FDiskas commented Nov 26, 2020

All major IDE has built-in ability fix eslint issues on save and this is not bad expanse for fast developing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants