-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sentry-release
deploy task
#77
feat: add sentry-release
deploy task
#77
Conversation
6b9319c
to
14607ae
Compare
14607ae
to
182bb71
Compare
@kseniyashaydurova I am unable to login into sentry |
charts/tekton-pipelines/templates/buildpacks/trigger-templates/_buildpack.yaml
Outdated
Show resolved
Hide resolved
charts/tekton-pipelines/templates/common/tasks/sentry-release.yaml
Outdated
Show resolved
Hide resolved
b40a1f3
to
553e484
Compare
@kseniyashaydurova when I'm opening release info it doesn't look like real info or "changes" associated with SHA commit? |
Also for django releases it shows all files in FILES CHANGED (127) - that feels like too much to me as well. |
It does, because we have not ignored |
It is ok too, Sentry releases works in the following scheme:
So in simple words for the very 1st release we will have a bunch of all commits, for the next ones - only commits between previous and new release. |
454363e
to
355c574
Compare
…tekton-apps, tekton-pipelines)
355c574
to
9bdee23
Compare
@dmitry-mightydevops I added fixes you asked, please check this PR again |
Add Sentry releases and sourcemaps (for frontend) functionality.
https://saritasa.atlassian.net/browse/SD-625 - add sourcemaps (frontend)
https://saritasa.atlassian.net/browse/SD-624 - add releases (python and other apps)
Tested on
ci-experiments
on rocks EKSfrontend:
django:
kaniko-backend:
kaniko-frontend:
Firstly I thought that adding
build-static
step to kaniko is good (i.e. we haveinteresnee-frontend
project, which is built by kaniko), but then I found that it won't work ok, because basically we usekaniko
deployments for frontend in cases, when we need to install some extra dependency, like https://github.com/saritasa-nest/interesnee-frontend/blob/develop/ci/docker/Dockerfile#L9 (https://tekton.saritasa.rocks/#/namespaces/ci-experiments/pipelineruns/saritasa-ci-experiments-kaniko-frontend-dev-kaniko-build-pb778t)So basically we wouldn't be able to prepare
static
for kaniko frontend projects, because to do this we need original docker image deps, which are only inside docker image. Also we are not able to copy built static from docker image during build process, because we will have to run docker image for that and copy stuff from inner folder to tekton build folder.So I suggest to make
sentry-sourcemaps
upload logic forkaniko-frontend
directly inside Dockerfile (if it is needed), we just add here Sentry related secrets as env vars only.This is what happens when Sentry Token becomes invalid (when Sentry client leaves us). - https://tekton.saritasa.rocks/#/namespaces/ci-experiments/pipelineruns/saritasa-ci-experiments-django-backend-dev-build-pipeline-cf5rk?pipelineTask=sentry-release&step=release