Add HTTP User-Agent to fetchJSON #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When can we expect this to be merged? Are you looking for more maintainers? cc: @sarumont |
|
Thanks for working out a fix to this issue folks. My site is not talking to Trello any more because of it. I second the question above: when can we expect this to be merged? |
identifysun
approved these changes
Mar 20, 2024
identifysun
reviewed
Mar 20, 2024
trello/trelloclient.py
Outdated
| @@ -215,6 +216,9 @@ def fetch_json( | |||
| if post_args is None: | |||
| post_args = {} | |||
|
|
|||
| # add user agent header to fetch_json requests | |||
| headers['User-Agent'] = generate_user_agent() | |||
|
|
|||
| # if files specified, we don't want any data | |||
| data = None | |||
| if files is None: | |||
There was a problem hiding this comment.
I tested your code and it is still not work? Is it possible to add a condition to the post_args parameter, the relevant statement is as follows:
if files is None and post_args and post_args != {}:
data = json.dumps(post_args)
|
See discussion re: repo's future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an HTTP User-Agent to all of the requests made by the client.
Recently, there was an issue where Trello put
api.trello.combehind CloudFront, which causedGETrequests with an empty body to return a 403 status code (see: #373).A fix for fixing GET requests with a body is already pending (see: #374).
For future possible issues, adding a User-Agent to this library will help Trello SREs identify where affected traffic is coming from, which means a better experience for users!