Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky shutdown #2312

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Fix flaky shutdown #2312

merged 8 commits into from
Aug 21, 2024

Commits on Aug 20, 2024

  1. Exit isolate on ProtocolError

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    558780f View commit details
    Browse the repository at this point in the history

  2. Remove intermediate StreamController

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0fb5183 View commit details
    Browse the repository at this point in the history

  3. Aggressively shutdown on ProtocolError

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a044ace View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
    @ntkme @nex3
    ntkme and nex3 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c3a937e View commit details
    Browse the repository at this point in the history

  5. Extract a common _receive() method and add comment for Isolate.exit()

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7134204 View commit details
    Browse the repository at this point in the history

  6. Convert assertions to throw StateError

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e6239ad View commit details
    Browse the repository at this point in the history

  7. Update comment

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    31cd86f View commit details
    Browse the repository at this point in the history

  8. Subscribe on each borrow

    @ntkme
    ntkme committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f8c2ffd View commit details
    Browse the repository at this point in the history