-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing double check test for sass-parser #2330
Conversation
tool/grind/double_check.dart
Outdated
var pubspecFile = File("$dir/pubspec.yaml"); | ||
if (pubspecFile.existsSync()) { | ||
var pubspec = Pubspec.parse(pubspecFile.readAsStringSync(), | ||
sourceUrl: p.toUri("$dir/pubspec.yaml")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sourceUrl: p.toUri("$dir/pubspec.yaml")); | |
sourceUrl: pubspecFile.uri); |
This also allows removal of import 'package:path/path.dart'
tool/grind/double_check.dart
Outdated
if (pubspec.version == package.latestPubspec.version) { | ||
fail("${pubspec.name} ${pubspec.version} has already been released!"); | ||
var pubspecFile = File("$dir/pubspec.yaml"); | ||
if (pubspecFile.existsSync()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: avoid excess indentation via
if (pubspecFile.existsSync()) { | |
if (!pubspecFile.existsSync()) continue; |
pubspec.yaml
Outdated
@@ -1,5 +1,5 @@ | |||
name: sass | |||
version: 1.78.0 | |||
version: 1.78.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since nothing has actually been released, we could remove the git tag, and then retag the same release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
c4a58de
to
18439e9
Compare
No description provided.