-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch 'main' of github.com:sass/embedded-host-node into feature.color-4 #256
Merged
Commits on Sep 8, 2023
-
Avoid relying on buggy import order in the legacy importer (#245)
Historically, the legacy importer shim has strongly assumed that all calls to `canonicalize()` would doubled: once as a URL resolved relative to the current importer, and again as a URL passed to the importers list. However, this relies on buggy, non-spec-compliant behavior in Dart Sass: absolute URLs should never be passed to the current importer, only to the global list of importers. This change avoids relying on that behavior by instead disambiguating relative loads using a custom URL protocol prefix. All canonical URLs passed to Dart Sass now have the prefix `legacy-importer-` added to the beginning. This allows us to disambiguate relative loads, and ignore them for non-`file:` URLs, since relative loads and _only_ relative loads will have schemes beginning with `legacy-importer-`. To avoid regressing the developer experience, we then strip these prefixes from all URLs before they're passed to any developer-facing APIs or displayed to the user.
Configuration menu - View commit details
-
Copy full SHA for 6129adf - Browse repository at this point
Copy the full SHA 6129adfView commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f7509e6 - Browse repository at this point
Copy the full SHA f7509e6View commit details
Commits on Sep 18, 2023
-
Properly include and export TypeScript types (#248)
We need to copy the entrypoing typings file, as described in [the TypeScript docs]: > It’s important to note that the CommonJS entrypoint and the ES > module entrypoint each needs its own declaration file, even if the > contents are the same between them. Every declaration file is > interpreted either as a CommonJS module or as an ES module, based on > its file extension and the `"type"` field of the `package.json`, and > this detected module kind must match the module kind that Node will > detect for the corresponding JavaScript file for type checking to be > correct. Attempting to use a single `.d.ts` file to type both an ES > module entrypoint and a CommonJS entrypoint will cause TypeScript to > think only one of those entrypoints exists, causing compiler errors > for users of the package. [the TypeScript docs]: https://www.typescriptlang.org/docs/handbook/esm-node.html Closes #247
Configuration menu - View commit details
-
Copy full SHA for ffa9947 - Browse repository at this point
Copy the full SHA ffa9947View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e7a23a - Browse repository at this point
Copy the full SHA 8e7a23aView commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37acf72 - Browse repository at this point
Copy the full SHA 37acf72View commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1784d46 - Browse repository at this point
Copy the full SHA 1784d46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6849715 - Browse repository at this point
Copy the full SHA 6849715View commit details
Commits on Oct 2, 2023
-
Bump minipass from 7.0.3 to 7.0.4 (#254)
Bumps [minipass](https://github.com/isaacs/minipass) from 7.0.3 to 7.0.4. - [Changelog](https://github.com/isaacs/minipass/blob/main/CHANGELOG.md) - [Commits](isaacs/minipass@v7.0.3...v7.0.4) --- updated-dependencies: - dependency-name: minipass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 79ab091 - Browse repository at this point
Copy the full SHA 79ab091View commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c9dee9b - Browse repository at this point
Copy the full SHA c9dee9bView commit details -
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9e354f0 - Browse repository at this point
Copy the full SHA 9e354f0View commit details
Commits on Oct 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ec75b8f - Browse repository at this point
Copy the full SHA ec75b8fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.