Fix error with deprecation warnings and legacy importers #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
suggested changes
Oct 15, 2024
lib/src/legacy/utils.ts
Outdated
| const url = removeLegacyImporter(span.url.toString()); | ||
| return { | ||
| ...span, | ||
| url: URL.canParse(url) |
There was a problem hiding this comment.
URL.canParse requires node >= 19.9.0, so better do a try - catch instead.
https://developer.mozilla.org/en-US/docs/Web/API/URL/canParse_static#browser_compatibility
nex3
requested changes
Oct 15, 2024
lib/src/legacy/utils.ts
Outdated
| return {...span, url: new URL(url)}; | ||
| } catch (_) { | ||
| // Relative URL | ||
| return {...span, url: new URL(url, `file://${process.cwd()}`)}; |
There was a problem hiding this comment.
Just shoving a pathname into a URL string isn't safe in general. Use Node's pathToFileUrl().
lib/src/legacy/utils.ts
Outdated
| const url = removeLegacyImporter(span.url.toString()); | ||
| try { | ||
| return {...span, url: new URL(url)}; | ||
| } catch (_) { |
There was a problem hiding this comment.
If the URL is absolute, it won't use the basename anyway, so you can just pass it in eagerly rather than catching this error.
nex3
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3898.
See sass/sass-spec#2004.
See sass/dart-sass#2282.