Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sketch data features docstring #9544

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fix/sketch data features docstring #9544

merged 3 commits into from
Dec 16, 2024

Conversation

dcollins15
Copy link
Contributor

Includes the features parameter in the docstring for the SketchData function. Currently, the missing documentation is causing the following WARNING to be thrown during CRAN checks:

❯ checking Rd \usage sections ... WARNING
  Undocumented arguments in Rd file 'SketchData.Rd'
    ‘features’

This warning also causes the check-package workflow to fail. Once this PR is out of draft, we can update the branch rules for develop to require jobs to succeed for PRs to be merged.

Relates to:

@dcollins15 dcollins15 force-pushed the fix/SketchData-features-docstring branch from 6c17b78 to 04f4485 Compare December 13, 2024 12:22
@dcollins15 dcollins15 marked this pull request as ready for review December 13, 2024 12:39
@dcollins15 dcollins15 requested a review from rsatija December 13, 2024 12:39
@dcollins15 dcollins15 mentioned this pull request Dec 13, 2024
Merged
@dcollins15 dcollins15 merged commit d752a89 into develop Dec 16, 2024
3 checks passed
@dcollins15 dcollins15 deleted the fix/SketchData-features-docstring branch December 16, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsatija rsatija rsatija approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcollins15 @rsatija