Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the web app and parsing output to use newly processed Satisfactory game data (per PR title: 1.2 experimental), including a small parser robustness tweak and a regenerated gameData.json.
Changes:
- Bumped web
dataVersionto reference the newly processed dataset. - Added a guard in power-recipe parsing to skip fuels whose part metadata is missing (instead of crashing).
- Regenerated
parsing/gameData.jsonwith the updated processed game data.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
web/src/config/config.ts |
Updates the referenced data version (1.0-30). |
parsing/src/recipes.ts |
Skips power fuels missing from items.parts, logging a warning. |
parsing/gameData.json |
Regenerated processed game data for the new version. |
Comments suppressed due to low confidence (2)
parsing/gameData.json:54
items.parts.AluminumIngot.nameis set to "Alternate: Pure Aluminum Ingot", but the same file contains a separate alternate recipe with that displayName that producesAluminumIngot. The part name should remain the item name (e.g., "Aluminum Ingot") rather than inheriting an alternate recipe’s display name; otherwise the UI will show the ingot with an alternate-recipe label. RegenerategameData.jsonafter adjusting the parsing so part names come from the item descriptor (or otherwise don’t use alternate recipe displayNames when populatingitems.parts).
This issue also appears on line 854 of the same file.
"AluminumIngot": {
"name": "Alternate: Pure Aluminum Ingot",
"stackSize": 100,
"isFluid": false,
"isFicsmas": false,
"energyGeneratedInMJ": 0
parsing/gameData.json:859
items.parts.Silica.nameis "Alumina Solution" even thoughitems.parts.AluminaSolutionis defined separately as the fluid item. This creates an internal inconsistency (and will mislabel Silica everywhere it’s referenced). RegenerategameData.jsonafter fixing the parsing so byproducts (like Silica from the Alumina Solution recipe) don’t overwrite the actual part’s display name.
"Silica": {
"name": "Alumina Solution",
"stackSize": 200,
"isFluid": false,
"isFicsmas": false,
"energyGeneratedInMJ": 0
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This is only tested on the experimental version of 1.2, and shouldn't be merged with main until 1.2 launches and this is confirmed to still be accurate.
Note
no new products or recipes in 1.2 experimental
This pull request introduces several improvements to recipe parsing and power handling, updates game data to version 1.2-00, and fixes naming inconsistencies. The main changes ensure that only valid production buildings are considered, handle missing fuel parts gracefully, and update game data and configuration to the latest version.