Skip to content

fix: processed 1.2 experimental game files#433

Open
samsmithnz wants to merge 7 commits intomainfrom
1.2-experimental
Open

fix: processed 1.2 experimental game files#433
samsmithnz wants to merge 7 commits intomainfrom
1.2-experimental

Conversation

@samsmithnz
Copy link
Collaborator

@samsmithnz samsmithnz commented Mar 17, 2026

Warning

This is only tested on the experimental version of 1.2, and shouldn't be merged with main until 1.2 launches and this is confirmed to still be accurate.

Note

no new products or recipes in 1.2 experimental

This pull request introduces several improvements to recipe parsing and power handling, updates game data to version 1.2-00, and fixes naming inconsistencies. The main changes ensure that only valid production buildings are considered, handle missing fuel parts gracefully, and update game data and configuration to the latest version.

Copilot AI review requested due to automatic review settings March 17, 2026 17:31
@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
satisfactory-factories Ready Ready Preview, Comment Mar 17, 2026 11:10pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the web app and parsing output to use newly processed Satisfactory game data (per PR title: 1.2 experimental), including a small parser robustness tweak and a regenerated gameData.json.

Changes:

  • Bumped web dataVersion to reference the newly processed dataset.
  • Added a guard in power-recipe parsing to skip fuels whose part metadata is missing (instead of crashing).
  • Regenerated parsing/gameData.json with the updated processed game data.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

File Description
web/src/config/config.ts Updates the referenced data version (1.0-30).
parsing/src/recipes.ts Skips power fuels missing from items.parts, logging a warning.
parsing/gameData.json Regenerated processed game data for the new version.
Comments suppressed due to low confidence (2)

parsing/gameData.json:54

  • items.parts.AluminumIngot.name is set to "Alternate: Pure Aluminum Ingot", but the same file contains a separate alternate recipe with that displayName that produces AluminumIngot. The part name should remain the item name (e.g., "Aluminum Ingot") rather than inheriting an alternate recipe’s display name; otherwise the UI will show the ingot with an alternate-recipe label. Regenerate gameData.json after adjusting the parsing so part names come from the item descriptor (or otherwise don’t use alternate recipe displayNames when populating items.parts).

This issue also appears on line 854 of the same file.

            "AluminumIngot": {
                "name": "Alternate: Pure Aluminum Ingot",
                "stackSize": 100,
                "isFluid": false,
                "isFicsmas": false,
                "energyGeneratedInMJ": 0

parsing/gameData.json:859

  • items.parts.Silica.name is "Alumina Solution" even though items.parts.AluminaSolution is defined separately as the fluid item. This creates an internal inconsistency (and will mislabel Silica everywhere it’s referenced). Regenerate gameData.json after fixing the parsing so byproducts (like Silica from the Alumina Solution recipe) don’t overwrite the actual part’s display name.
            "Silica": {
                "name": "Alumina Solution",
                "stackSize": 200,
                "isFluid": false,
                "isFicsmas": false,
                "energyGeneratedInMJ": 0

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants