fix: Skip rendering JUnit&JSON reporters when running in async mode (#…

…810) * fix: Skip downloading reporters when running in async mode * refine a bit * fix bug * revert changes
saucelabs · Jul 20, 2023 · 2f2a66b · 2f2a66b
1 parent cbea780
commit 2f2a66b
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/internal/cmd/run/cucumber.go b/internal/cmd/run/cucumber.go
@@ -145,7 +145,7 @@ func runCucumber(cmd *cobra.Command, isCLIDriven bool) (int, error) {
 			Region:          regio,
 			ShowConsoleLog:  p.ShowConsoleLog,
 			Reporters: createReporters(p.Reporters, p.Notifications, p.Sauce.Metadata, &testcompClient, &restoClient,
-				"cucumber", "sauce"),
+				"cucumber", "sauce", gFlags.async),
 			Async:                  gFlags.async,
 			FailFast:               gFlags.failFast,
 			MetadataSearchStrategy: framework.NewSearchStrategy(p.Playwright.Version, p.RootDir),

diff --git a/internal/cmd/run/cypress.go b/internal/cmd/run/cypress.go
@@ -164,7 +164,7 @@ func runCypress(cmd *cobra.Command, isCLIDriven bool) (int, error) {
 			Region:          regio,
 			ShowConsoleLog:  p.IsShowConsoleLog(),
 			Reporters: createReporters(p.GetReporter(), p.GetNotifications(), p.GetSauceCfg().Metadata, &testcompClient, &restoClient,
-				"cypress", "sauce"),
+				"cypress", "sauce", gFlags.async),
 			Async:                  gFlags.async,
 			FailFast:               gFlags.failFast,
 			MetadataSearchStrategy: framework.NewSearchStrategy(p.GetVersion(), p.GetRootDir()),

diff --git a/internal/cmd/run/espresso.go b/internal/cmd/run/espresso.go
@@ -168,7 +168,7 @@ func runEspressoInCloud(p espresso.Project, regio region.Region) (int, error) {
 			Region:          regio,
 			ShowConsoleLog:  p.ShowConsoleLog,
 			Reporters: createReporters(p.Reporters, p.Notifications, p.Sauce.Metadata, &testcompClient, &restoClient,
-				"espresso", "sauce"),
+				"espresso", "sauce", gFlags.async),
 			Framework: framework.Framework{Name: espresso.Kind},
 			Async:     gFlags.async,
 			FailFast:  gFlags.failFast,

diff --git a/internal/cmd/run/playwright.go b/internal/cmd/run/playwright.go
@@ -179,7 +179,7 @@ func runPlaywright(cmd *cobra.Command, isCLIDriven bool) (int, error) {
 			Region:          regio,
 			ShowConsoleLog:  p.ShowConsoleLog,
 			Reporters: createReporters(p.Reporters, p.Notifications, p.Sauce.Metadata, &testcompClient, &restoClient,
-				"playwright", "sauce"),
+				"playwright", "sauce", gFlags.async),
 			Async:                  gFlags.async,
 			FailFast:               gFlags.failFast,
 			MetadataSearchStrategy: framework.NewSearchStrategy(p.Playwright.Version, p.RootDir),

diff --git a/internal/cmd/run/replay.go b/internal/cmd/run/replay.go
@@ -153,7 +153,7 @@ func runPuppeteerReplayInSauce(p replay.Project, regio region.Region) (int, erro
 			Region:          regio,
 			ShowConsoleLog:  p.ShowConsoleLog,
 			Reporters: createReporters(p.Reporters, p.Notifications, p.Sauce.Metadata, &testcompClient, &restoClient,
-				"puppeteer-replay", "sauce"),
+				"puppeteer-replay", "sauce", gFlags.async),
 			Async:                  gFlags.async,
 			FailFast:               gFlags.failFast,
 			MetadataSearchStrategy: framework.ExactStrategy{},

diff --git a/internal/cmd/run/run.go b/internal/cmd/run/run.go
@@ -282,7 +282,7 @@ func checkForUpdates() {
 }
 
 func createReporters(c config.Reporters, ntfs config.Notifications, metadata config.Metadata,
-	svc slack.Service, buildReader build.Reader, framework, env string) []report.Reporter {
+	svc slack.Service, buildReader build.Reader, framework, env string, async bool) []report.Reporter {
 	buildReporter := buildtable.New(buildReader)
 	githubReporter := github.NewJobSummaryReporter()
 
@@ -292,13 +292,13 @@ func createReporters(c config.Reporters, ntfs config.Notifications, metadata con
 		&githubReporter,
 	}
 
-	if c.JUnit.Enabled {
+	if !async && c.JUnit.Enabled {
 		reps = append(reps, &junit.Reporter{
 			Filename: c.JUnit.Filename,
 		})
 	}
 
-	if c.JSON.Enabled {
+	if !async && c.JSON.Enabled {
 		reps = append(reps, &json.Reporter{
 			WebhookURL: c.JSON.WebhookURL,
 			Filename:   c.JSON.Filename,

diff --git a/internal/cmd/run/testcafe.go b/internal/cmd/run/testcafe.go
@@ -201,7 +201,7 @@ func runTestcafe(cmd *cobra.Command, tcFlags testcafeFlags, isCLIDriven bool) (i
 			Region:          regio,
 			ShowConsoleLog:  p.ShowConsoleLog,
 			Reporters: createReporters(p.Reporters, p.Notifications, p.Sauce.Metadata, &testcompClient, &restoClient,
-				"testcafe", "sauce"),
+				"testcafe", "sauce", gFlags.async),
 			Async:                  gFlags.async,
 			FailFast:               gFlags.failFast,
 			MetadataSearchStrategy: framework.NewSearchStrategy(p.Testcafe.Version, p.RootDir),

diff --git a/internal/cmd/run/xcuitest.go b/internal/cmd/run/xcuitest.go
@@ -166,7 +166,7 @@ func runXcuitestInCloud(p xcuitest.Project, regio region.Region) (int, error) {
 			Region:          regio,
 			ShowConsoleLog:  p.ShowConsoleLog,
 			Reporters: createReporters(p.Reporters, p.Notifications, p.Sauce.Metadata, &testcompClient, &restoClient,
-				"xcuitest", "sauce"),
+				"xcuitest", "sauce", gFlags.async),
 			Framework: framework.Framework{Name: xcuitest.Kind},
 			Async:     gFlags.async,
 			FailFast:  gFlags.failFast,