Conversation
- fresh connection per query, fixing cascading transaction errors (#727) - parse /dbname/tablename from URL for direct table access (#282) - postgres_user/password/host/port options override URL values (#522) - exec-sql and edit-sql commands (#586) - INSERT/UPDATE/DELETE via primary keys with deferred saves (#579) - PgTablesSheet now extends IndexSheet with iterload - only pass connection params that are specified (unix socket works) - add dev/setup-postgres.sh and tests/test-postgres.sh Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- TESTING.md: never use -o /dev/stdout in batch tests - STYLE.md: rowid() must use calcValue() for deferred sheets - STYLE.md: only pass specified psycopg2 connection params Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InFailedSqlTransactionerrorspostgres:///dbname/tablenameopens a table directly, skipping the tables sheetpostgres_user,postgres_password,postgres_host,postgres_portoptions override URL values (for passwords that can't be URL-encoded)exec-sqlandedit-sqlcommands on postgres sheets, with SQL sidebarz Ctrl+Sto commit)PgTablesSheetnow extendsIndexSheetwithiterloadpatternpostgres:///dbname)Closes #282, closes #522, closes #579, closes #586, closes #727
Test plan
dev/setup-postgres.shto create local test databasedev/test-all.sh tests/test-postgres.shpassesdev/test-all.sh— all existing tests still passvd postgres:///vdtest— tables sheet, Enter to open benchmarkvd postgres:///vdtest/benchmark— direct table accessz Ctrl+Sto commit changesexec-sqlcommand to run raw SQL🤖 Generated with Claude Code