Fix fixed-width loader for right-justified headers#3043
Open
Fix fixed-width loader for right-justified headers#3043
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
@frosencrantz I'd appreciate you testing this if you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
psoutput withPID PPID) caused data loss because column starts were derived from header text positionsallNonspacescomputation that adjustscolstartsto actual data boundaries — no other logic changedApproach
The #2265 fix correctly uses the header to determine column positions (preventing false splits from data with internal spaces). But when headers are right-justified, data extends left of where header text starts.
After computing
allNonspaces, the fix:colstarts[0]to 0 if data exists before the first header wordTest plan
test_fixed_width.pytests pass (including newtest_right_justified_headers)ps aux | vd -f fixedor similar right-justified fixed-width output🤖 Generated with Claude Code