Fix #498 - Romanian inflect is wrong for mega and giga values, add te… #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a values, add tests that replicated the issue and capture potential regressions, fix wrong tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sts that replicated the issue and capture potential regressions, fix wrong tests
Fixes #498 by...
Changes proposed in this pull request:
Changed Romanian inflect() logic for mega and giga values in order to add
debefore plural when (value corresponding to that order of magnitude) % 100 >= 20 and nothing otherwise aka between 1 .. 19 inclusive.Status
How to verify this change
Just run the tests and should all pass. Note that only those for Romanian language were touched.