Add Bulgarian language implementation #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilingDima
reviewed
May 5, 2023
| words.append(self.pluralize(chunk, SCALE[chunk_len])) | ||
|
|
||
| return ' '.join(words) | ||
|
|
There was a problem hiding this comment.
It is not a good decision to put boolean feminine parameter, because you have 3 genders - masculine, feminine and neuter. Later it will be a problem with backward compatibility.
Like here.
I suggest adding the gender parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Add Bulgarian language implementation
Status
How to verify this change
Additional notes
Used daily in our codebase in a private fork. Would like to contribute upstream and clean up our deployment process.