-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Bangla language support to num2word for Bangladesh. #589
base: master
Are you sure you want to change the base?
Conversation
Can you please re-run the CI . I have fixed the isort and flake8 issues. |
idk, why coverage is failing I have my files are cover 99% with test. Can you merge this PR and see coverage after merge. |
I may have same issue as this PR: |
@SkiBY can you review and run ci and workflow. |
@SkiBY can you help me , file: num2words/init.py and CONVERTER_CLASSES = { |
Coverage tests are a little bit unfair. Your coverage is marked as 100%, so you could help to increase a coverage for some languages you know. |
It's tough to understand other countries native . So It would not be much help if I write test which I don't understand ! |
Changes proposed in this pull request:
Status
How to verify this change
run test for verification.