Add Armenian (HY) language support#635
Merged
mrodriguezg1991 merged 13 commits intosavoirfairelinux:masterfrom May 30, 2025
Merged
Add Armenian (HY) language support#635mrodriguezg1991 merged 13 commits intosavoirfairelinux:masterfrom
mrodriguezg1991 merged 13 commits intosavoirfairelinux:masterfrom
Conversation
This commit adds full support for the Armenian language to the num2words library with the following features: Complete implementation of cardinal numbers in Armenian; Support for ordinal numbers with appropriate suffixes; Support for years with special cases handling; Currency support for multiple currencies including AMD, EUR, USD and others; Proper pluralization rules for Armenian nouns; Modern numeral representation using Arabic digits; Comprehensive test suite to ensure correctness. The implementation follows Armenian grammar rules and provides correct pronunciation for all numeric forms.
Contributor
|
Hello @xdownedx |
Contributor
Author
ready |
…tter branch coverage
…l, and year prefix edge cases with real Armenian words. Also add flake8 style fixes.
…date tests for joined forms, and ensure correct million grouping. All tests now pass.
…nches and lines in test_hy.py
Contributor
Author
|
@mrodriguezg1991 hey, please check my pr |
Contributor
Author
|
@mrodriguezg1991 can you review my pr? |
mrodriguezg1991
approved these changes
May 30, 2025
Contributor
Done, sorry for the delay, There will be a release , some point next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds full support for the Armenian language to the num2words library with the following features: Complete implementation of cardinal numbers in Armenian; Support for ordinal numbers with appropriate suffixes; Support for years with special cases handling; Currency support for multiple currencies including AMD, EUR, USD and others; Proper pluralization rules for Armenian nouns; Modern numeral representation using Arabic digits; Comprehensive test suite to ensure correctness. The implementation follows Armenian grammar rules and provides correct pronunciation for all numeric forms.
Adding Armenian language support
Changes proposed in this pull request:
Status
How to verify this change
Run the tests for Armenian language with
python -m pytest tests/test_hy.py -vto verify all functionality. You can also manually test with examples like:Additional notes
The implementation follows modern Armenian (Eastern Armenian) grammar rules and provides support for all standard num2words features. Currency support includes major international currencies with proper Armenian naming conventions.