dht_proxy_server: add push notification statistics #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsimonfc
force-pushed
the
dhtproxy_stats
branch
from
85bdc08
to
c1e14d6
Compare
fsimonfc
force-pushed
the
dhtproxy_stats
branch
from
c1e14d6
to
67169ae
Compare
aberaud
requested changes
Nov 4, 2024
| @@ -98,6 +98,32 @@ class OPENDHT_PUBLIC DhtProxyServer | |||
|
|
|||
| asio::io_context& io_context() const; | |||
|
|
|||
| struct PushStats { | |||
| uint64_t highPriorityCount {0}; | |||
There was a problem hiding this comment.
It was simpler to add a mutex since this struct gets copied in updateStats and that doesn't work with atomic types, hope that's ok but let me know if you'd prefer a different solution.
| @@ -98,6 +98,32 @@ class OPENDHT_PUBLIC DhtProxyServer | |||
|
|
|||
| asio::io_context& io_context() const; | |||
|
|
|||
| struct PushStats { | |||
| uint64_t highPriorityCount {0}; | |||
| uint64_t normalPriorityCount {0}; | |||
include/opendht/dht_proxy_server.h
Outdated
Comment on lines
120
to
123
| std::ostringstream ss; | ||
| ss << highPriorityCount << " high priority, " | ||
| << normalPriorityCount << " normal priority"; | ||
| return ss.str(); |
There was a problem hiding this comment.
fmt::format("{} high priority, {} normal priority", highPriorityCount, normalPriorityCount);
fsimonfc
force-pushed
the
dhtproxy_stats
branch
from
67169ae
to
9c821d0
Compare
fsimonfc
force-pushed
the
dhtproxy_stats
branch
from
9c821d0
to
a025895
Compare
aberaud
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.