Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: crossfade, muxer rewrite, fix add #3612

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Cleanup: crossfade, muxer rewrite, fix add #3612

merged 8 commits into from
Jan 4, 2024

Conversation

toots
Copy link
Member

@toots toots commented Jan 4, 2024

This PR cleans up some of the recent changes:

One important change: fade.in and fade.out used to be triggered by track marks by default. However, with these changes and to be more in-tune with the new handling of track marks, the sources used to compute crossfade transitions do not have initial track marks unless they are in the underlying data.

Since most use of fade.in and fade.out are inside crossfade transitions it seems to make sense to change them to trigger immediately. The old behavior can still be obtained by passing track_sensitive=true.

@toots toots changed the title Cleanup Cleanup: crossfade, muxer rewrite, fix add Jan 4, 2024
@toots toots marked this pull request as ready for review January 4, 2024 22:13
@toots toots added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit a64945b Jan 4, 2024
26 checks passed
@toots toots deleted the cleanup branch January 4, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant