Cleanup: crossfade, muxer rewrite, fix add #3612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some of the recent changes:
add
operatorSource.generate_from_multiple_sources
logic.One important change:
fade.in
andfade.out
used to be triggered by track marks by default. However, with these changes and to be more in-tune with the new handling of track marks, the sources used to compute crossfade transitions do not have initial track marks unless they are in the underlying data.Since most use of
fade.in
andfade.out
are inside crossfade transitions it seems to make sense to change them to trigger immediately. The old behavior can still be obtained by passingtrack_sensitive=true
.