TRIB-210: adds save cosign endpoint #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creates SaveCosign endpoint in Connect controller - creates SaveCosign annotation in controller annotations
- updated ConnectAPIController to send individual IDs to service instead of request dto - updated CosignService and imple to accept individual ids as params - reasoning: more consistent with existing code, more clear to read, better for testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/connect-page #147 +/- ##
=======================================================
Coverage ? 75.27%
Complexity ? 644
=======================================================
Files ? 97
Lines ? 1970
Branches ? 268
=======================================================
Hits ? 1483
Misses ? 444
Partials ? 43 ☔ View full report in Codecov by Sentry. |
- isFileExistingHappyPath
- isFileExistingSadPath
- deleteHappyPath
haxwell
merged commit 69cedc1
into
savvato-software:feature/connect-page
3 checks passed
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I am submitting this early (with questions and incomplete test) to review at our meeting 1/11/2024
Questions:
Changes:
Testing (WIP)