Trib 199 #149
Merged
Trib 199 #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-fixed compile errors and syntax errors
Added ResponseEntity to endpoint to adhere to mythical style guide
-Formatted response entities with correct status codes
modified api route to sent an object instead of a boolen response entity NotificationAPIController.java modified genericmessageDto to use a new service GenericMessageService.java -added interface for createMessageDTO GenericMessageServiceImpl.java -added function createMessageDTO NotificationService.java -removed interface for createMessageDTO NotificationServiceImpl.java -removed function createMessageDTO
…ooleen. pages affected: AttributesAPIController.java AuthAPIController.java NotificationAPIController.java PermissionsAPIController.java ProfileAPIController.java GenericMessageService.java GenericMessageServiceImpl.java
haxwell
approved these changes
Feb 2, 2024
-added a bracket that was deleted and broke the code.
-Updated test to reflect new genericDTO with new service location
haxwell
requested changes
Feb 8, 2024
|
@loretdemolas Is this PR still necessary? |
Fixed AttributesAPITest by including genericMessageDTO service to the test, Broke AuthAPITest and ConnectAPITest
-fixed imports and fixed unit test
-Fixed API test by using andExpect(jsonPath) instead of creating an object to compare it too.
Fix test involving genericDto's booleanMessage
-Fixed test involving GenericMessageDTO
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #149 +/- ##
=============================================
+ Coverage 75.42% 75.58% +0.15%
- Complexity 652 655 +3
=============================================
Files 98 99 +1
Lines 1994 2007 +13
Branches 269 269
=============================================
+ Hits 1504 1517 +13
Misses 446 446
Partials 44 44 ☔ View full report in Codecov by Sentry. |
added test to test the different methods
fix syntax issue
haxwell
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.