TRIB-174: Ensure user count is included when attribute is returned #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's review this one in person in tonight's meeting. Nothing really wrong, but there's more work, and it's easier to discuss in person. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #152 +/- ##
=============================================
- Coverage 75.42% 75.34% -0.09%
+ Complexity 652 646 -6
=============================================
Files 98 99 +1
Lines 1994 1983 -11
Branches 269 260 -9
=============================================
- Hits 1504 1494 -10
- Misses 446 451 +5
+ Partials 44 38 -6 ☔ View full report in Codecov by Sentry. |
…seId method temporarily
- Project JOIN query result to PhraseWithUserCountDTO
maryamkhan14
force-pushed
the
trib-174
branch
from
750ec99 to
8809b11
Compare
haxwell
approved these changes
Feb 21, 2024
| public record PhraseWithUserCountDTO(Long id, Long adverbId, Long verbId, Long prepositionId, Long nounId, | ||
| Long userCount) { | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Why do you override the equals() method, rather than use the generated method?
Also, we need to create another ticket to change the rest of the DTOs to records, so we can maintain consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our meeting discussions, attribute user count should be included in the information returned when an attribute is requested by its ID. This would eliminate the need for a separate endpoint that fetches attribute user count, so this PR removes that endpoint and ensures that user count is incorporated in the information returned upon attribute requests.