mrsbluerose: removes duplicate work in DB scripts #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maryam's script 202312071653 is implemented before Audra's script 202401291541, making Audra's script unnecessary and causing SQL errors - caused by confusion in rebuild. Both accomplish most of the same work renaming the Connect table's header columns with the underscore format
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
==========================================
Coverage 75.42% 75.42%
Complexity 652 652
==========================================
Files 98 98
Lines 1994 1994
Branches 269 269
==========================================
Hits 1504 1504
Misses 446 446
Partials 44 44 ☔ View full report in Codecov by Sentry. |
haxwell
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate work in Maryam’s script: 202312071653 and Audra’s script: 202401291541 caused a SQL error when running the backend. Removed my (Audra’s) script. Both scripts were renaming columns, and since mine was technically listed after Maryam’s, the columns my script was referencing no longer existed.